-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ModalSubmitInteraction Typings #7768
Fix ModalSubmitInteraction Typings #7768
Conversation
I believe it should not have a
|
Modals do receive the payload if it was from a component!{
t: 'INTERACTION_CREATE',
s: 4,
op: 0,
d: {
version: 1,
type: 5,
token: 'token',
message: {
type: 0,
tts: false,
timestamp: '2022-02-16T19:09:35.384000+00:00',
pinned: false,
mentions: [],
mention_roles: [],
mention_everyone: false,
id: '943584917885960303',
flags: 0,
embeds: [],
edited_timestamp: null,
content: 'Do you have any feedback for us? Do you wish to alert us of misbehaviour within the friends chat or Discord server? <#942814460769366057> is the place to be!\n' +
'\n' +
"If you are attempting to report an ongoing situation that needs immediate attention, feel free to mention the <@&886323824822456357> role and we'll respond accordingly.\n" +
'\n' +
'Please interact with the respective button to get started!',
components: [Array],
channel_id: '942814460769366057',
author: [Object],
attachments: []
},
member: {
user: [Object],
roles: [Array],
premium_since: null,
permissions: '4398046511103',
pending: false,
nick: null,
mute: false,
joined_at: '2021-09-11T18:54:26.945000+00:00',
is_pending: false,
flags: 0,
deaf: false,
communication_disabled_until: null,
avatar: null
},
locale: 'en-GB',
id: '963055469386149944',
guild_locale: 'en-US',
guild_id: '886323824801488996',
data: { custom_id: 'MAIL_SOULOBBY_REPORT', components: [Array] },
channel_id: '942814460769366057',
application_id: '559093467264057344'
}
} This pull request is a backport of #7705 anyhow and needs amending. |
Hi @sasial-dev, can you look at #7705 and made the necessary changes here? It should match! Seems there is only one change left to do. |
|
You need to modify this: Line 1900 in 1563bb5
|
I said you need to modify it! Look at the upstream pull request and compare. |
1563bb5
to
afdb34d
Compare
Apologies for the misunderstanding - all sorted :) |
Stuffed up the rebase, sorry. |
fb40118
to
afdb34d
Compare
afdb34d
to
5dfffc7
Compare
^ Rebased through Github UI, seemed to have fixed it (but didn't sign) |
@Mateo-tem, can you re-review? |
Please describe the changes this PR makes and why it should be merged:
Fix typings not existing for already existing code.
https://github.com/discordjs/discord.js/blob/v13/src/structures/ModalSubmitInteraction.js#L47-L51
Status and versioning classification: